Github user VinceShieh commented on a diff in the pull request:
https://github.com/apache/spark/pull/14858#discussion_r76569900
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala
---
@@ -129,17 +129,21 @@ object Bucketizer extends
DefaultParamsReadable[Bucketizer] {
if (feature == splits.last) {
splits.length - 2
} else {
- val idx = ju.Arrays.binarySearch(splits, feature)
- if (idx >= 0) {
- idx
+ if (feature.isNaN) {
+ splits.length - 1
--- End diff --
index NaN value as ${splits.length -1}
''' all the other changes within this files, without comments, are just for
code refactoring
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
