Github user srinathshankar commented on a diff in the pull request: https://github.com/apache/spark/pull/14866#discussion_r76716719 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala --- @@ -159,23 +159,30 @@ object ExtractEquiJoinKeys extends Logging with PredicateHelper { */ object ExtractFiltersAndInnerJoins extends PredicateHelper { - // flatten all inner joins, which are next to each other - def flattenJoin(plan: LogicalPlan): (Seq[LogicalPlan], Seq[Expression]) = plan match { - case Join(left, right, Inner, cond) => - val (plans, conditions) = flattenJoin(left) - (plans ++ Seq(right), conditions ++ cond.toSeq) + /** + * Flatten all inner joins, which are next to each other. + * Return a list of logical plans to be joined with a boolean for each plan indicating if it + * was involved in an explicit cross join. Also returns the entire list of join conditions for + * the left-deep tree. + */ + def flattenJoin(plan: LogicalPlan, parentJoinType: Inner = Inner(false)) --- End diff -- Done.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org