Github user srinathshankar commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r76857357
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -642,7 +642,7 @@ class LogicalPlanToSQLSuite extends SQLBuilderTest with
SQLTestUtils {
checkColumnNames(
"""SELECT x.a, y.a, x.b, y.b
|FROM (SELECT 1 AS a, 2 AS b) x
- |INNER JOIN (SELECT 1 AS a, 2 AS b) y
+ |CROSS JOIN (SELECT 1 AS a, 2 AS b) y
--- End diff --
The join condition is eliminated because it is "trivial" according to the
foldable propagation rule. This is annoying, but an expected by-product of
detecting joins in the optimization phase. I can check to see if there is a way
to split up the operator optimization batch so the cartesian check can be
inserted before the constant propagation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
