Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14926#discussion_r77309831
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -392,10 +397,36 @@ private[spark] class ExecutorAllocationManager(
}
/**
- * Request the cluster manager to remove the given executor.
+ * Request the cluster manager to remove the given executors.
* Return whether the request is received.
*/
- private def removeExecutor(executorId: String): Boolean = synchronized {
+ private def removeExecutors(executorIds: Seq[String]): Boolean =
synchronized {
+
+ val executorIdsToBeRemoved = executorIds.filter(canBeKilled)
+
+ // Send a request to the backend to kill this executor
+ val removeRequestAcknowledged = testing ||
client.killExecutors(executorIdsToBeRemoved)
--- End diff --
Is there a risk that somehow _some_ of the executors are killed and not
others? The code kinda assumes now that all or none succeed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
