Github user erikerlandson commented on the pull request:
https://github.com/apache/spark/pull/1964#issuecomment-52848633
I like where this RFE is going.
One comment about "metric" versus "measure" - cosine distance is a subclass
of DistanceMeasure, as it is *not* a metric. Others should be subclasses of
DistanceMetric, such as manhattan, L2, etc. Others of them I'm not sure of,
but recommend to verify which ones are true metrics, and which are just
measures.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
