Github user erikerlandson commented on the pull request:
https://github.com/apache/spark/pull/1964#issuecomment-52858495
I feel ambiguous about whether there needs to be a sub-trait for
WeightedDistanceMeasure, but if we have that then we will also need a
WeightedDistanceMetric as a subtrait of DistanceMetric.
or as an alternative just define a trait Weighted, and then:
class WeightedEuclideanDistanceMetric(val weight: Vector) extends
DistsanceMetric with Weighted
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
