Github user eyalfa commented on the issue:
https://github.com/apache/spark/pull/14444
that was basically the idea behind the trait you requested me to remove...
the thing is I don't feel it belongs to CreateNamedStruct, so I settled for
putting it in CreateStruct and reusing it in CreateStructUnsafe.
a better approach might be adding a toUnsafe method on CreateNamedStruct,
this could be usefull as most of the time the unsafe version is built from the
safe version (without even touching the children), what do you think about this
approach?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
