Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14444
I didn't like the trait because it added another layer of complexity
(inheritance) to a relatively simple problem. The only thing you need is a
shared method. That can be located anywhere.
The conversion from the safe to the unsafe is an internal matter, that code
is only touched when we are doing code generation. The only place we use this
is in `UnsafeProjection`. So we don't really need any kind of scaffolding in
place; I would just drop the entire concept of `CreateUnsafeRow`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
