Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r77798210
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -90,6 +98,14 @@ object DateTimeUtils {
}
}
+ // A wrapper function to apply date related functions with timestamps.
This truncates
+ // time parts.
+ private def dateFuncToTimestampFunc(
+ timestamp: SQLTimestamp,
+ dateFunc: (SQLDate) => SQLDate): SQLTimestamp = {
+ daysToMillis(dateFunc(millisToDays(timestamp / 1000L))) * 1000L
--- End diff --
You are using this once. Lets just inline it with a comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
