Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r78003977
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -322,9 +322,9 @@ object FunctionRegistry {
expression[CurrentDate]("current_date"),
expression[CurrentTimestamp]("current_timestamp"),
expression[DateDiff]("datediff"),
- expression[DateAdd]("date_add"),
+ expression[AddDays]("date_add"),
--- End diff --
I may understand why hive call it `date_add`...
Other databases also have `date_add`, but it takes interval type, which
means it can handle days or months or both.
To keep hive-compatibility, we should keep it as it was, but rename the
expression class name LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
