Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14990#discussion_r77952714
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -626,189 +629,25 @@ abstract class TreeNode[BaseType <:
TreeNode[BaseType]] extends Product {
("deserialized" -> s.deserialized) ~ ("replication" ->
s.replication)
case n: TreeNode[_] => n.jsonValue
case o: Option[_] => o.map(parseToJson)
- case t: Seq[_] => JArray(t.map(parseToJson).toList)
- case m: Map[_, _] =>
- val fields = m.toList.map { case (k: String, v) => (k,
parseToJson(v)) }
- JObject(fields)
- case r: RDD[_] => JNothing
+ // Recursive scan Seq[TreeNode]
+ case t: Seq[_] if t.length > 0 && t.head.isInstanceOf[TreeNode[_]] =>
+ JArray(t.map(parseToJson).toList)
// if it's a scala object, we can simply keep the full class path.
// TODO: currently if the class name ends with "$", we think it's a
scala object, there is
// probably a better way to check it.
case obj if obj.getClass.getName.endsWith("$") => "object" ->
obj.getClass.getName
- // returns null if the product type doesn't have a primary
constructor, e.g. HiveFunctionWrapper
+ case t: Seq[_] => JNull
--- End diff --
Yes, we need this, as some Seq is also a Product.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
