Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14990#discussion_r77953015
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -597,7 +597,10 @@ abstract class TreeNode[BaseType <:
TreeNode[BaseType]] extends Product {
// this child in all children.
case (name, value: TreeNode[_]) if containsChild(value) =>
name -> JInt(children.indexOf(value))
- case (name, value: Seq[BaseType]) if
value.toSet.subsetOf(containsChild) =>
+ // Check the value (Seq[BaseType]) element type first before
converting it to a Set.
+ // Otherwise, it may take a lot of memory to convert a super big Seq
to Set.
--- End diff --
Good idea.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
