Github user xwu0226 commented on a diff in the pull request: https://github.com/apache/spark/pull/14842#discussion_r78268093 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala --- @@ -71,12 +95,34 @@ case class SortPrefix(child: SortOrder) extends UnaryExpression { val nullValue = child.child.dataType match { case BooleanType | DateType | TimestampType | _: IntegralType => - Long.MinValue + if ((child.isAscending && child.nullOrdering == NullFirst) || + (!child.isAscending && child.nullOrdering == NullLast)) { + Long.MinValue + } else { + Long.MaxValue + } case dt: DecimalType if dt.precision - dt.scale <= Decimal.MAX_LONG_DIGITS => - Long.MinValue + if ((child.isAscending && child.nullOrdering == NullFirst) || + (!child.isAscending && child.nullOrdering == NullLast)) { + Long.MinValue + } else { + Long.MaxValue + } case _: DecimalType => - DoublePrefixComparator.computePrefix(Double.NegativeInfinity) - case _ => 0L + if ((child.isAscending && child.nullOrdering == NullFirst) || + (!child.isAscending && child.nullOrdering == NullLast)) { + DoublePrefixComparator.computePrefix(Double.NegativeInfinity) + } else { + DoublePrefixComparator.computePrefix(Double.NaN) + } + case _ => + if ((child.isAscending && child.nullOrdering == NullFirst) || + (!child.isAscending && child.nullOrdering == NullLast)) { + 0L + } else { + // This may not be the best choice for null value for BinaryType + DoublePrefixComparator.computePrefix(Double.NaN) --- End diff -- I see. Thanks!
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org