Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/14842#discussion_r78269938
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/PrefixComparators.java
---
@@ -69,48 +86,96 @@ public static long computePrefix(double value) {
* ordering they define is compatible with radix sort.
*/
public abstract static class RadixSortSupport extends PrefixComparator {
+
/** @return Whether the sort should be descending in binary sort
order. */
public abstract boolean sortDescending();
/** @return Whether the sort should take into account the sign bit. */
public abstract boolean sortSigned();
+
+ /** @return Whether the sort should put null first or last. */
+ public abstract boolean nullFirst();
}
//
// Standard prefix comparator implementations
//
+ // unsigned asc null first (default)
public static final class UnsignedPrefixComparator extends
RadixSortSupport {
@Override public boolean sortDescending() { return false; }
@Override public boolean sortSigned() { return false; }
- @Override
+ @Override public boolean nullFirst() { return true; }
public int compare(long aPrefix, long bPrefix) {
return UnsignedLongs.compare(aPrefix, bPrefix);
}
}
+ // unsigned asc null last
--- End diff --
nit: remove these comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
