Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14959#discussion_r78453870
--- Diff: python/pyspark/java_gateway.py ---
@@ -51,13 +51,16 @@ def launch_gateway():
on_windows = platform.system() == "Windows"
script = "./bin/spark-submit.cmd" if on_windows else
"./bin/spark-submit"
submit_args = os.environ.get("PYSPARK_SUBMIT_ARGS",
"pyspark-shell")
+ if conf and conf.getAll():
+ submit_args = ' '.join(['--conf %s="%s"' % (k, v) for k, v in
conf.getAll()]) \
--- End diff --
I think it would be better to create a separate list for the `--conf`
arguments, and concatenate it into the `command` variable below. Then you don't
need to worry about the values of the arguments causing trouble.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
