Github user rnowling commented on the pull request:

    https://github.com/apache/spark/pull/1964#issuecomment-53010747
  
    Overall, changes look great!  Thank you for considering our feedback.
    
    I like that you were able to reduce the number of files.  I think 
SquaredEuclideanDistanceMeasure.scala probably needs to deleted -- it looks 
empty.  
    
    I'm wondering if the tests should be compacted as well?  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to