Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/15060#discussion_r78697410
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
---
@@ -235,6 +235,7 @@ class MultilayerPerceptronClassifier @Since("1.5.0") (
*/
override protected def train(dataset: Dataset[_]):
MultilayerPerceptronClassificationModel = {
val myLayers = $(layers)
+ require(myLayers != null, "layers parameter not set.")
--- End diff --
is this really required? because `$layers` should call `getOrDefault` and
if there is no default and it is not set, it already throws an erorr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
