Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/15060#discussion_r78697474
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -545,7 +545,8 @@ private[ann] object FeedForwardModel {
* @return model
*/
def apply(topology: FeedForwardTopology, weights: Vector):
FeedForwardModel = {
- // TODO: check that weights size is equal to sum of layers sizes
+ require(weights.size == topology.layers.map(_.weightSize).sum,
+ "Input weight vector has illegal size.")
--- End diff --
Prefer a more informative error message here, like "Expected weight vector
of size $x but got size $y"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
