Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r79362014
--- Diff:
mesos/src/main/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcherArguments.scala
---
@@ -73,37 +94,55 @@ private[mesos] class
MesosClusterDispatcherArguments(args: Array[String], conf:
propertiesFile = value
parse(tail)
+ case ("--conf") :: value :: tail =>
+ MesosClusterDispatcher.
+ parseSparkConfProperty(value, (k: String, v: String) =>
confProperties(k) = v)
+ parse(tail)
+
case ("--help") :: tail =>
- printUsageAndExit(0)
+ printUsageAndExit(0)
+
+ case ("--verbose") :: tail =>
+ verbose = true
+ parse(tail)
case Nil =>
- if (masterUrl == null) {
+ if (Option(masterUrl).isEmpty) {
// scalastyle:off println
- System.err.println("--master is required")
+ MesosClusterDispatcher.printStream.println("--master is required")
// scalastyle:on println
printUsageAndExit(1)
}
- case _ =>
+ case value@_ =>
--- End diff --
Its the same thing case value => less verbose. Will change it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
