Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14650#discussion_r79417055
--- Diff:
mesos/src/main/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcherArguments.scala
---
@@ -18,23 +18,43 @@
package org.apache.spark.deploy.mesos
import scala.annotation.tailrec
+import scala.collection.mutable
-import org.apache.spark.SparkConf
import org.apache.spark.util.{IntParam, Utils}
-
+import org.apache.spark.SparkConf
private[mesos] class MesosClusterDispatcherArguments(args: Array[String],
conf: SparkConf) {
- var host = Utils.localHostName()
- var port = 7077
- var name = "Spark Cluster"
- var webUiPort = 8081
+ var host: String = Utils.localHostName()
+ var port: Int = 7077
+ var name: String = "Spark Cluster"
+ var webUiPort: Int = 8081
+ var verbose: Boolean = false
var masterUrl: String = _
var zookeeperUrl: Option[String] = None
var propertiesFile: String = _
+ val confProperties: mutable.HashMap[String, String] =
+ new mutable.HashMap[String, String]()
parse(args.toList)
+ // scalastyle:on println
propertiesFile = Utils.loadDefaultSparkProperties(conf, propertiesFile)
+ Utils.updateSparkConfigFromProperties(conf, confProperties)
--- End diff --
I guess I mean, why isn't this same code then called elsewhere? You know
more about this than I, but I suppose I'd expect more parallel similarity
between the Mesos and non-Mesos code, for supporting the same functionality.
There's a method factored out here but not reused. Marcelo may understand this
more anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
