Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/14079#discussion_r79914706
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -50,22 +49,26 @@ import org.apache.spark.util.{AccumulatorV2, Clock,
SystemClock, Utils}
* task set will be aborted
*/
private[spark] class TaskSetManager(
- sched: TaskSchedulerImpl,
+ val sched: TaskSchedulerImpl,
+ val blacklistTracker: Option[BlacklistTracker],
val taskSet: TaskSet,
val maxTaskFailures: Int,
- clock: Clock = new SystemClock())
+ val clock: Clock)
extends Schedulable with Logging {
- val conf = sched.sc.conf
+ def this(
+ sched: TaskSchedulerImpl,
+ taskSet: TaskSet,
+ maxTaskFailures: Int,
+ clock: Clock = new SystemClock()) {
+ this(sched, None, taskSet, maxTaskFailures, clock)
--- End diff --
only a really minor reason -- multiple default params don't work as nicely,
all the call sites which only specify a `clock` now have to say `clock =
clock`. (while with multiple constructors, the types are enough to figure out
what to do.) but this doesn't really matter, I'll update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
