Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2065#discussion_r16682789
  
    --- Diff: 
external/flume-sink/src/main/scala/org/apache/spark/streaming/flume/sink/SparkAvroCallbackHandler.scala
 ---
    @@ -46,6 +48,10 @@ private[flume] class SparkAvroCallbackHandler(val 
threads: Int, val channel: Cha
         new ThreadFactoryBuilder().setDaemon(true)
           .setNameFormat("Spark Sink Processor Thread - %d").build()))
       private val processorMap = new ConcurrentHashMap[CharSequence, 
TransactionProcessor]()
    --- End diff --
    
    For better code understanding, it is better to call this 
`sequenceNumberToProcessor` (this style is often used in Spark, see 
DAGScheduler) and the `processorsToShutdown` to be called `activeProcessors`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to