Github user harishreedharan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2065#discussion_r16683530
  
    --- Diff: 
external/flume-sink/src/main/scala/org/apache/spark/streaming/flume/sink/SparkAvroCallbackHandler.scala
 ---
    @@ -124,6 +139,8 @@ private[flume] class SparkAvroCallbackHandler(val 
threads: Int, val channel: Cha
        */
       def shutdown() {
         logInfo("Shutting down Spark Avro Callback Handler")
    +    stopped = true
    +    processorsToShutdown.foreach(_.shutdown())
    --- End diff --
    
    Yes, you are right. We can put that code inside a lock to take care of 
this. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to