Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15239#discussion_r80850317
--- Diff: R/pkg/R/SQLContext.R ---
@@ -328,6 +328,7 @@ setMethod("toDF", signature(x = "RDD"),
#' It goes through the entire dataset once to determine the schema.
#'
#' @param path Path of file to read. A vector of multiple paths is allowed.
+#' @param ... additional external data source specific named properties.
--- End diff --
Yes, it was not. I am not very sure on this (as actually I am not used to
this CRAN check). My guess is, it seems they combine the arguments? For
example, Parquet API is as below:
```r
#' @param path path of file to read. A vector of multiple paths is allowed.
#' @return SparkDataFrame
#' @rdname read.parquet
...
read.parquet.default <- function(path, ...) {
```
```r
#' @param ... argument(s) passed to the method.
#' @rdname read.parquet
...
parquetFile.default <- function(...) {
```
It complained about duplicated `@params` when I tried to add `@param ...`
to `read.parquet.default`. So, I ended up with removing this back.
On the other hand, for JSON APIs,
```r
#' @rdname read.json
#' @name jsonFile
...
jsonFile.default <- function(path) {
```
```r
#' @param path Path of file to read. A vector of multiple paths is allowed.
#' @param ... additional external data source specific named properties.
#' @return SparkDataFrame
#' @rdname read.json
...
read.json.default <- function(path, ...) {
```
It seems `jsonFile` does not describe `@param`. So, I think it passed.
If you meant another problem, could you please guide me?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
