Github user wgtmac commented on a diff in the pull request:
https://github.com/apache/spark/pull/15248#discussion_r81062518
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala ---
@@ -179,7 +180,11 @@ class HistoryServer(
}
--- End diff --
Finally I found this approach also have some issues. Both live UI and
history UI depend on /api/v1/applications endpoint which uses UIRoot class to
get the app list. UIRoot has two subclasses: SparkUI and HistoryServer.
SparkUI's getApplicationList() returns iterator of ApplicationInfo directly,
and HistoryServer's getApplicationList() needs to map ApplicationHistoryInfo to
ApplicationInfo for the whole list which is the most time-consuming part. So it
is unavoidable to do the transformation for the whole list if we want to return
Iterator[ApplicationInfo] from getApplicationList(). I can add a method to
return Iterator[ApplicationHistoryInfo] in UIRoot class, but it makes no sense
for SparkUI to implement this irrelevant method. Finally I decided to add back
the getApplicationListView() method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
