Github user ajbozarth commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15248#discussion_r81207581
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala ---
    @@ -179,7 +180,11 @@ class HistoryServer(
       }
    --- End diff --
    
    A note parallel to what @srowen is saying here, if you look at this change 
alongside your other pr #15247 `getApplicationInfoList` is actually no longer 
used. So either change how it works to avoid adding the new view function or 
deleting it completely would be good options


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to