Github user sethah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11119#discussion_r83514617
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala 
---
    @@ -303,6 +313,23 @@ class KMeans @Since("1.5.0") (
       @Since("1.5.0")
       def setSeed(value: Long): this.type = set(seed, value)
     
    +  /** @group setParam */
    +  @Since("2.1.0")
    +  def setInitialModel(value: KMeansModel): this.type = {
    +    val kOfInitialModel = value.parentModel.clusterCenters.length
    +    if (isSet(k)) {
    +      if ($(k) != kOfInitialModel) {
    +        set(k, kOfInitialModel)
    +        logWarning(s"Param K is set to $kOfInitialModel by the 
initialModel." +
    --- End diff --
    
    The previous value is lost because you set it before logging this warning. 
Need to reorder the code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to