Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/11119#discussion_r83514641
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -303,6 +312,20 @@ class KMeans @Since("1.5.0") (
@Since("1.5.0")
def setSeed(value: Long): this.type = set(seed, value)
+ /** @group setParam */
--- End diff --
Yeah, so I think myself and Nick were under the impression that we would
simply ignore any calls to `setK` if initialModel is set. So,
````scala
def setK(value: Int): this.type = {
if (isSet(initialModel)) {
logWarning("initialModel is set, so k will be ignored. Clear
initialModel first.")
this
} else {
set(k, value)
}
}
````
@MLnick @dbtsai does that seem correct?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
