Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15212#discussion_r84042900
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/ChiSqSelectorSuite.scala ---
@@ -82,6 +82,18 @@ class ChiSqSelectorSuite extends SparkFunSuite with
MLlibTestSparkContext
case Row(vec1: Vector, vec2: Vector) =>
assert(vec1 ~== vec2 absTol 1e-1)
}
+
+ selector.setSelectorType("fwe").setAlpha(0.5).fit(df2).transform(df2)
+ .select("filtered", "preFilteredData").collect().foreach {
+ case Row(vec1: Vector, vec2: Vector) =>
+ assert(vec1 ~== vec2 absTol 1e-1)
+ }
+
+ selector.setSelectorType("fdr").setAlpha(0.21).fit(df2).transform(df2)
+ .select("filtered", "preFilteredData").collect().foreach {
+ case Row(vec1: Vector, vec2: Vector) =>
+ assert(vec1 ~== vec2 absTol 1e-1)
+ }
--- End diff --
Enforce this test case to large dimension data, and output different
selected features according to selector type as far as possible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
