Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15212#discussion_r84044410
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala ---
@@ -263,9 +278,15 @@ object ChiSqSelector {
/** String name for `fpr` selector type. */
private[spark] val FPR: String = "fpr"
+ /** String name for `fdr` selector type. */
+ private[spark] val FDR: String = "fdr"
--- End diff --
I know this applies to the existing line above too, but, this comment isn't
descriptive. You can spell out what all of these mean if there's javadoc at all
here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
