Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15428#discussion_r84563237
  
    --- Diff: python/pyspark/ml/feature.py ---
    @@ -1157,9 +1157,11 @@ class QuantileDiscretizer(JavaEstimator, 
HasInputCol, HasOutputCol, JavaMLReadab
         categorical features. The number of bins can be set using the 
:py:attr:`numBuckets` parameter.
         It is possible that the number of buckets used will be less than this 
value, for example, if
         there are too few distinct values of the input to create enough 
distinct quantiles. Note also
    -    that NaN values are handled specially and placed into their own 
bucket. For example, if 4
    -    buckets are used, then non-NaN data will be put into buckets(0-3), but 
NaNs will be counted in
    -    a special bucket(4).
    +    that QuantileDiscretizer will raise an error when it finds NaN value 
in the dataset, but user
    --- End diff --
    
    Actually no need to update Python API until it is updated to include 
handleNaN


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to