Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15428#discussion_r84731665
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala 
---
    @@ -73,15 +74,52 @@ final class Bucketizer @Since("1.4.0") (@Since("1.4.0") 
override val uid: String
       @Since("1.4.0")
       def setOutputCol(value: String): this.type = set(outputCol, value)
     
    +  /**
    +   * Param for how to handle invalid entries. Options are skip (which will 
filter out rows with
    +   * invalid values), or error (which will throw an error), or keep (which 
will keep the invalid
    +   * values in certain way). Default behaviour is to report an error for 
invalid entries.
    +   *
    +   * @group param
    +   */
    +  @Since("2.1.0")
    +  val handleInvalid: Param[String] = new Param[String](this, 
"handleInvalid", "how to handle" +
    +    "invalid entries. Options are skip (which will filter out rows with 
invalid values), or" +
    +    "error (which will throw an error), or keep (which will keep the 
invalid values" +
    +    " in certain way). Default behaviour is to report an error for invalid 
entries.",
    +    ParamValidators.inArray(Array("skip", "error", "keep")))
    +
    +  /** @group getParam */
    +  @Since("2.1.0")
    +  def gethandleInvalid: Option[Boolean] = $(handleInvalid) match {
    --- End diff --
    
    This should just return ```$(handleInvalid)```, just like any other Param 
getter method.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to