Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15603#discussion_r84640346
--- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala ---
@@ -93,15 +91,15 @@ private[spark] class SparkUI private (
/** Stop the server behind this web interface. Only valid after bind().
*/
override def stop() {
super.stop()
- logInfo("Stopped Spark web UI at %s".format(appUIAddress))
+ logInfo(s"Stopped Spark web UI at $appUIAddress")
}
/**
* Return the application UI host:port. This does not include the scheme
(http://).
*/
private[spark] def appUIHostPort = publicHostName + ":" + boundPort
- private[spark] def appUIAddress = s"http://$appUIHostPort";
+ private[spark] def appUIAddress = webUrl
--- End diff --
I think these two methods can just be eliminated, because appUIAddress does
seem to return exactly the same thing, and appUIHostPort is only referenced
from tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
