Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15603#discussion_r84640931
--- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala ---
@@ -135,7 +133,7 @@ private[spark] class SparkUI private (
private[spark] abstract class SparkUITab(parent: SparkUI, prefix: String)
extends WebUITab(parent, prefix) {
- def appName: String = parent.getAppName
+ def appName: String = parent.appName
--- End diff --
This can just be removed then, because this becomes a no-op. And then
getAppName in the superclass can be removed. It's a pointless getter.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
