Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15621#discussion_r85133777
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -137,61 +133,68 @@ private[ml] class WeightedLeastSquares(
}
}
- // scale aBar to standardized space in-place
- val aBarValues = aBar.values
- var j = 0
- while (j < numFeatures) {
- if (aStd(j) == 0.0) {
- aBarValues(j) = 0.0
- } else {
- aBarValues(j) /= aStd(j)
- }
- j += 1
- }
+ val bBar = summary.bBar / bStd
--- End diff --
Since we use ```bBar, bbBar, aBar, abBar, aaBar``` in standardized space
always, so I did not append ```Std``` as suffix for all variables. If we only
add suffix for ```bBar``` and ```bbBar```, developers may misinterpret that
other variables are not in standardized space.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
