Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/15621#discussion_r85134771
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -137,61 +133,68 @@ private[ml] class WeightedLeastSquares(
}
}
- // scale aBar to standardized space in-place
- val aBarValues = aBar.values
- var j = 0
- while (j < numFeatures) {
- if (aStd(j) == 0.0) {
- aBarValues(j) = 0.0
- } else {
- aBarValues(j) /= aStd(j)
- }
- j += 1
- }
+ val bBar = summary.bBar / bStd
+ val bbBar = summary.bbBar / (bStd * bStd)
- // scale abBar to standardized space in-place
- val abBarValues = abBar.values
- val aStdValues = aStd.values
- j = 0
- while (j < numFeatures) {
- if (aStdValues(j) == 0.0) {
- abBarValues(j) = 0.0
- } else {
- abBarValues(j) /= (aStdValues(j) * bStd)
+ val aStd = summary.aStd
+ val aBar = {
+ val _aBar = summary.aBar
+ var i = 0
+ // scale aBar to standardized space in-place
+ while (i < numFeatures) {
+ if (aStd(i) == 0.0) {
+ _aBar.values(i) = 0.0
--- End diff --
Yeah, I total agree. I thought the impact of this issue is trivial, but
making implicit pointer definitely should be better. I made update for all
variables. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
