Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15513#discussion_r85184264
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/xml/xpath.scala
---
@@ -94,9 +122,19 @@ case class XPathInt(xml: Expression, path: Expression)
extends XPathExtract {
}
}
+// scalastyle:off line.size.limit
@ExpressionDescription(
- usage = "_FUNC_(xml, xpath) - Returns a long value that matches the
xpath expression",
- extended = "> SELECT _FUNC_('<a><b>1</b><b>2</b></a>','sum(a/b)');\n3")
+ usage = "_FUNC_(xml, xpath) - Returns a long value, or the value zero if
no match is found, or a match is found but the value is non-numeric.",
--- End diff --
`a long value` is confusing. We should use `a long integer value`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
