Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15513#discussion_r85221940
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
 ---
    @@ -251,7 +259,12 @@ case class InSet(child: Expression, hset: Set[Any]) 
extends UnaryExpression with
     }
     
     @ExpressionDescription(
    -  usage = "a _FUNC_ b - Logical AND.")
    +  usage = "expr1 _FUNC_ expr2 - Logical AND.",
    +  extended = """
    +    Arguments:
    +      expr1 - an expression of any type.
    +      expr2 - an expression of any type.
    --- End diff --
    
    Are you sure it can support any type?
    
    For logical operations (AND, OR or others), I think the only acceptable 
types are boolean


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to