Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/15354#discussion_r85248697
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala
---
@@ -123,8 +122,9 @@ private[sql] class JacksonGenerator(
case _ =>
(row: SpecializedGetters, ordinal: Int) =>
val v = row.get(ordinal, dataType)
- sys.error(s"Failed to convert value $v (class of ${v.getClass}}) "
+
- s"with the type of $dataType to JSON.")
+ throw new SparkSQLJsonProcessingException(
+ s"Failed to convert value $v (class of ${v.getClass}}) " +
+ s"with the type of $dataType to JSON.")
--- End diff --
I would avoid this change since its throwing a private exception type to
the user now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
