Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15354#discussion_r85583042
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
    @@ -2936,6 +2936,51 @@ object functions {
       def from_json(e: Column, schema: String, options: java.util.Map[String, 
String]): Column =
         from_json(e, DataType.fromJson(schema).asInstanceOf[StructType], 
options)
     
    +
    +  /**
    +   * (Scala-specific) Converts a column containing a [[StructType]] into a 
JSON string
    +   * ([[http://jsonlines.org/ JSON Lines text format or newline-delimited 
JSON]]) with the
    +   * specified schema. Throws an exception, in the case of an unsupported 
type.
    +   *
    +   * @param e a struct column.
    +   * @param options options to control how the struct column is converted 
into a json string.
    +   *                accepts the same options and the json data source.
    +   *
    +   * @group collection_funcs
    +   * @since 2.1.0
    +   */
    +  def to_json(e: Column, options: Map[String, String]): Column = withExpr {
    +    StructToJson(options, e.expr)
    +  }
    +
    +  /**
    +   * (Java-specific) Converts a column containing a [[StructType]] into a 
JSON string
    +   * ([[http://jsonlines.org/ JSON Lines text format or newline-delimited 
JSON]]) with the
    +   * specified schema. Throws an exception, in the case of an unsupported 
type.
    +   *
    +   * @param e a struct column.
    +   * @param options options to control how the struct column is converted 
into a json string.
    +   *                accepts the same options and the json data source.
    +   *
    +   * @group collection_funcs
    +   * @since 2.1.0
    +   */
    +  def to_json(e: Column, options: java.util.Map[String, String]): Column =
    +    to_json(e, options.asScala.toMap)
    +
    +  /**
    +   * Converts a column containing a [[StructType]] into a JSON string
    +   * ([[http://jsonlines.org/ JSON Lines text format or newline-delimited 
JSON]]) with the
    --- End diff --
    
    I don't think that this case really follows "JSON lines".  It is a string 
inside of a larger dataframe.  There are no newlines involved.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to