Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15651#discussion_r85265891
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
    @@ -482,6 +483,33 @@ class Dataset[T] private[sql](
       @InterfaceStability.Evolving
       def isStreaming: Boolean = logicalPlan.isStreaming
     
    +  @Experimental
    +  @InterfaceStability.Evolving
    +  def checkpoint(): Dataset[T] = {
    +    val internalRdd = queryExecution.toRdd.map(_.copy())
    +    internalRdd.checkpoint()
    +
    +    val physicalPlan = queryExecution.executedPlan
    +
    +    def firstLeafPartitioning(partitioning: Partitioning): Partitioning = {
    +      partitioning match {
    +        case p: PartitioningCollection => 
firstLeafPartitioning(p.partitionings.head)
    +        case p => p
    +      }
    +    }
    --- End diff --
    
    Are the partitioning other than the first useful? Can we just filter out 
the partitioning guaranteed by other partitionings instead of picking the first 
only?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to