Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15651#discussion_r85266229
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -130,17 +130,23 @@ case class ExternalRDDScanExec[T](
/** Logical plan node for scanning data from an RDD of InternalRow. */
case class LogicalRDD(
output: Seq[Attribute],
- rdd: RDD[InternalRow])(session: SparkSession)
+ rdd: RDD[InternalRow],
+ outputPartitioning: Partitioning = UnknownPartitioning(0),
+ outputOrdering: Seq[SortOrder] = Nil)(session: SparkSession)
extends LeafNode with MultiInstanceRelation {
override protected final def otherCopyArgs: Seq[AnyRef] = session :: Nil
- override def newInstance(): LogicalRDD.this.type =
- LogicalRDD(output.map(_.newInstance()),
rdd)(session).asInstanceOf[this.type]
+ override def newInstance(): LogicalRDD.this.type = LogicalRDD(
+ output.map(_.newInstance()),
+ rdd,
+ outputPartitioning,
+ outputOrdering
--- End diff --
Do we need to convert the old attributes in `outputPartitioning` and
`outputOrdering` to new attributes? Otherwise the partitioning and ordering are
still referring to old attributes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
