Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15705#discussion_r85859910
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
 ---
    @@ -345,18 +346,32 @@ case class BroadcastHint(child: LogicalPlan) extends 
UnaryNode {
       override lazy val statistics: Statistics = 
super.statistics.copy(isBroadcastable = true)
     }
     
    +/**
    + * Options for writing new data into a table.
    + *
    + * @param enabled whether to overwrite existing data in the table.
    --- End diff --
    
    it's pretty confusing we call it `enabled`, can we just use `overwrite`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to