Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15705#discussion_r85870248
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -173,12 +175,22 @@ case class DataSourceAnalysis(conf: CatalystConf)
extends Rule[LogicalPlan] {
case LogicalRelation(r: HadoopFsRelation, _, _) =>
r.location.rootPaths
}.flatten
- val mode = if (overwrite) SaveMode.Overwrite else SaveMode.Append
- if (overwrite && inputPaths.contains(outputPath)) {
+ val mode = if (overwrite.enabled) SaveMode.Overwrite else
SaveMode.Append
+ if (overwrite.enabled && inputPaths.contains(outputPath)) {
throw new AnalysisException(
"Cannot overwrite a path that is also being read from.")
}
+ val overwritePartitionPath = if
(overwrite.specificPartition.isDefined &&
--- End diff --
can we just pass the partition path as `outputPath` to
`InsertIntoHadoopFsRelationCommand` and set partition columns to `Nil`, then we
don't need to add an extra parameter to `InsertIntoHadoopFsRelationCommand`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
