Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15024#discussion_r86065681
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -189,11 +189,11 @@ private[spark] class HiveExternalCatalog(conf:
SparkConf, hadoopConf: Configurat
throw new TableAlreadyExistsException(db = db, table = table)
}
// Before saving data source table metadata into Hive metastore, we
should:
- // 1. Put table provider, schema, partition column names, bucket
specification and partition
- // provider in table properties.
+ // 1. Put table provider, location URI, schema, partition column
names, bucket specification
+ // and partition provider in table properties.
--- End diff --
Could we create a separate function for [this
step](https://github.com/cloud-fan/spark/blob/97f04cf246e70e411a2693232e5a54f7542a17f2/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala#L206-L248)?
The related codes become longer and longer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
