Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/15024#discussion_r86070959 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -513,6 +555,16 @@ private[spark] class HiveExternalCatalog(conf: SparkConf, hadoopConf: Configurat tableWithStats.copy(properties = getOriginalTableProperties(table)) } + private def getLocationFromRawTable(rawTable: CatalogTable): Option[String] = { + rawTable.properties.get(TABLE_LOCATION).orElse { + // In older version of spark, we store the table location in storage properties with key + // `path`, instead of table properties with key `spark.sql.tableLocation`. We should --- End diff -- Why do we need `spark.sql.tableLocation` instead of just relying on hive's location field and path in serde properties?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org