Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15024#discussion_r86075163
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/PathOptionSuite.scala ---
@@ -0,0 +1,97 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
+* contributor license agreements. See the NOTICE file distributed with
+* this work for additional information regarding copyright ownership.
+* The ASF licenses this file to You under the Apache License, Version 2.0
+* (the "License"); you may not use this file except in compliance with
+* the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+
+package org.apache.spark.sql.sources
+
+import org.apache.spark.sql.{DataFrame, SaveMode, SparkSession, SQLContext}
+import org.apache.spark.sql.catalyst.TableIdentifier
+import org.apache.spark.sql.execution.datasources.LogicalRelation
+import org.apache.spark.sql.test.SharedSQLContext
+import org.apache.spark.sql.types.StructType
+
+class TestOptionsSource extends RelationProvider with
CreatableRelationProvider {
+
+ override def createRelation(
+ sqlContext: SQLContext,
+ parameters: Map[String, String]): BaseRelation = {
+ new TestOptionsRelation(parameters)(sqlContext.sparkSession)
+ }
+
+ override def createRelation(
+ sqlContext: SQLContext,
+ mode: SaveMode,
+ parameters: Map[String, String],
+ data: DataFrame): BaseRelation = {
+ new TestOptionsRelation(parameters)(sqlContext.sparkSession)
+ }
+}
+
+class TestOptionsRelation(val options: Map[String, String])(@transient val
session: SparkSession)
+ extends BaseRelation {
+
+ override def sqlContext: SQLContext = session.sqlContext
+
+ override def schema: StructType = new StructType().add("i", "int")
+}
+
+class PathOptionSuite extends DataSourceTest with SharedSQLContext {
+
+ test("path option always exist") {
+ withTable("src") {
+ sql(
+ s"""
+ |CREATE TABLE src(i int)
+ |USING ${classOf[TestOptionsSource].getCanonicalName}
+ |OPTIONS (PATH '/tmp/path')""".stripMargin)
+ assert(getPathOption("src") == Some("/tmp/path"))
+ }
+
+ // should exist even path option is not specified when creating table
+ withTable("src") {
+ sql(s"CREATE TABLE src(i int) USING
${classOf[TestOptionsSource].getCanonicalName}")
+ assert(getPathOption("src") == Some(defaultTablePath("src")))
+ }
+ }
+
+ test("path option always represent the value of table location") {
+ withTable("src") {
+ sql(
+ s"""
+ |CREATE TABLE src(i int)
+ |USING ${classOf[TestOptionsSource].getCanonicalName}
+ |OPTIONS (PATH '/tmp/path')""".stripMargin)
+ sql("ALTER TABLE src SET LOCATION '/tmp/path2'")
+ assert(getPathOption("src") == Some("/tmp/path2"))
+ }
+
+ withTable("src", "src2") {
+ sql(s"CREATE TABLE src(i int) USING
${classOf[TestOptionsSource].getCanonicalName}")
+ sql("ALTER TABLE src RENAME TO src2")
--- End diff --
This test case is still calling the `InMemoryCatalog.renameTable`. Thus, we
still need a test case to verify the behavior of
`HiveExternalCatalog.renameTable`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
