Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15484#discussion_r86075526 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -229,10 +235,14 @@ class Analyzer( * Group Count: 2 ^ N (N is the number of group expressions) * * We need to get all of its subsets for a given GROUPBY expression, the subsets are - * represented as the bit masks. + * represented as sequence of expressions. */ - def bitmasks(c: Cube): Seq[Int] = { - Seq.tabulate(1 << c.groupByExprs.length)(i => i) + def cubeExprs(exprs: Seq[Expression]): Seq[Seq[Expression]] = exprs.toList match { --- End diff -- Also I think you can just use subsets? e.g. ``` scala> Seq(1, 2, 3).toSet.subsets.foreach(println) Set() Set(1) Set(2) Set(3) Set(1, 2) Set(1, 3) Set(2, 3) Set(1, 2, 3) ```
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org