Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15172#discussion_r86850097
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
---
@@ -175,4 +176,26 @@ public boolean saslServerAlwaysEncrypt() {
return conf.getBoolean("spark.network.sasl.serverAlwaysEncrypt",
false);
}
+ /**
+ * The trigger for enabling AES encryption.
+ */
+ public boolean aesEncryptionEnabled() {
+ return conf.getBoolean("spark.authenticate.encryption.aes.enabled",
false);
+ }
+
+ /**
+ * The implementation class for crypto cipher
+ */
+ public String aesCipherClass() {
+ return conf.get("spark.authenticate.encryption.aes.cipher.class",
+ CryptoCipherFactory.CipherProvider.OPENSSL.getClassName());
--- End diff --
This does not match the default value of the library. You should not use a
default here; just use "null" as a trigger for "do not set a value", and let
the library deal with the default.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
