Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15172#discussion_r87295803
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/sasl/SaslClientBootstrap.java
---
@@ -88,9 +90,20 @@ public void doBootstrap(TransportClient client, Channel
channel) {
throw new RuntimeException(
new SaslException("Encryption requests by negotiated
non-encrypted connection."));
}
- SaslEncryption.addToChannel(channel, saslClient,
conf.maxSaslEncryptedBlockSize());
+
+ if (conf.aesEncryptionEnabled()) {
+ // Generate a request config message to send to server.
+ AesConfigMessage configMessage =
AesCipher.createConfigMessage(conf);
+ ByteBuffer buf = configMessage.encodeMessage();
+ client.sendRpcSync(buf, conf.saslRTTimeoutMs());
--- End diff --
Wait. Isn't this now sending the keys in plain text over the wire?
I commented before that using 3des to encrypt the keys is sub-optimal, but
I didn't mean for you to remove the encryption altogether.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
